Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: batch rpc #112

Merged
merged 2 commits into from
Nov 1, 2023
Merged

feat: batch rpc #112

merged 2 commits into from
Nov 1, 2023

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Nov 1, 2023

Description

  • feat: batch rpc
    image

  • increased minimum CGL to 35k - we're having issues with the native transfer in Gnosis chain and occasionally on Optimism

  • added env variable naming to the config param for setting minimum CGL

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -232,7 +240,7 @@ const bundlerDefaultConfigs: BundlerConfig = {
banSlack: 10,
minSignerBalance: utils.parseEther("0.1"),
multicall: "0xcA11bde05977b3631167028862bE2a173976CA11", // default multicall address
estimationStaticBuffer: 21000,
estimationStaticBuffer: 35000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the default CGL value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's the minimum value for CGL

@0xSulpiride 0xSulpiride merged commit f488645 into master Nov 1, 2023
4 of 5 checks passed
@0xSulpiride 0xSulpiride deleted the batch-rpc branch November 1, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants